Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template(spa): Provide example of server that can handle SPA routes #8707

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Feb 7, 2024

Because this also fixes the typo of "yo" -> "to" this pull request supersedes #8639.

Because http-server isn't able to serve the index.html file as a fallback for what would otherwise be 404 routes (see #8624) it is best to suggest a different server to preview or run a built SPA application. This change doesn't change how the start script in package.json uses http-server because that is not specifically addressed in the README.md.

This change includes part of the README.md updates from #8624, but without the changes to packages/remix-dev/vite/plugin.ts needed to support vite preview.

Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 85ac9b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

templates/spa/README.md Outdated Show resolved Hide resolved
templates/spa/README.md Outdated Show resolved Hide resolved
@brophdawg11 brophdawg11 added feat:spa Issues related to SPA Mode docs template:spa and removed template:spa labels Feb 8, 2024
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11 brophdawg11 merged commit 1fc94dd into remix-run:main Feb 9, 2024
2 checks passed
@ngbrown ngbrown deleted the update-spa-readme branch February 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed docs feat:spa Issues related to SPA Mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants