-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use isbot version 4 #8385
Conversation
🦋 Changeset detectedLatest commit: b058d6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @fifi98, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thanks!! |
Unfortunately, I realized we can't upgrade to v4 like this after all because it would be a breaking change to existing apps with v3 pinned in their deps who have not run |
This reverts commit 3fb4195.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
The latest
isbot
version 3 has been marked as deprecated in favour of the version 4 which is going to become the "latest" version on npm on January 2024 (https://github.com/omrilotan/isbot).Version 4 includes some breaking changes listed here: https://github.com/omrilotan/isbot/blob/next/CHANGELOG.md. The main point of this release seems to be reducing the package size and improving performance.
This pull requests makes Remix use the latest
isbot
version, which is 4.1.0 at the moment. Templates and docs have been also updated to reflect that change.Closes #8407