Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use isbot version 4 #8385

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Conversation

fifi98
Copy link
Contributor

@fifi98 fifi98 commented Dec 27, 2023

The latest isbot version 3 has been marked as deprecated in favour of the version 4 which is going to become the "latest" version on npm on January 2024 (https://github.com/omrilotan/isbot).

Version 4 includes some breaking changes listed here: https://github.com/omrilotan/isbot/blob/next/CHANGELOG.md. The main point of this release seems to be reducing the package size and improving performance.

This pull requests makes Remix use the latest isbot version, which is 4.1.0 at the moment. Templates and docs have been also updated to reflect that change.

Closes #8407

Copy link

changeset-bot bot commented Dec 27, 2023

🦋 Changeset detected

Latest commit: b058d6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 27, 2023

Hi @fifi98,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 27, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 linked an issue Jan 2, 2024 that may be closed by this pull request
@brophdawg11 brophdawg11 added package:dev dependencies Pull requests that update a dependency file labels Jan 2, 2024
@brophdawg11 brophdawg11 self-assigned this Jan 2, 2024
@brophdawg11 brophdawg11 linked an issue Jan 2, 2024 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit 3fb4195 into remix-run:dev Jan 2, 2024
9 checks passed
@brophdawg11
Copy link
Contributor

Thanks!!

@brophdawg11
Copy link
Contributor

Unfortunately, I realized we can't upgrade to v4 like this after all because it would be a breaking change to existing apps with v3 pinned in their deps who have not run npx remix reveal and are using the entry.server.tsx version built-into @remix-run/dev, since v3 does not export isbot as a named export. I'm going to revert this for now and we'll figure out the best way to solve this.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 2.5.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment