fix(dev): surface PostCSS config errors #7391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were swallowing errors when loading PostCSS config so that it didn't break the build for those without a PostCSS config, but this suppresses real errors for PostCSS consumers when there's a problem with their config.
This PR updates the logic so that we only swallow the missing config error and ensure that all other errors are thrown.
I've also refactored all CSS plugins so that the PostCSS config is loaded lazily rather than up-front in the
setup
hook. Without this change, consumers see the error coming from the first plugin that happens to be instantiated which is confusing if they're not using the feature, e.g. the error comes from the CSS Modules plugin when they're not using CSS Modules.