fix(react): fix useLoaderData types in Yarn PnP

[markdalgleish]

Fixes #6994

The useLoaderData return type depends on access to the SerializeFrom type exported by @remix-run/server-runtime. Since this package is listed as a dev dependency of @remix-run/react rather than a regular dependency, this type isn't currently available to consumers when running Yarn PnP.

[changeset-bot]

🦋 Changeset detected

Latest commit: 48329d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/react	Patch
@remix-run/testing	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/node	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[MichaelDeBoey]

This feels very weird to do so and makes me think about the initiative @pcattori started at some point to look into extracting certain packages

I think back then the decision was made to copy/paste certain types and maintain 2 versions of it (for now)

Maybe we should either do that here as well or since it's v2 it can be a perfect time to restart the initiative as well 🤔

[markdalgleish]

I chatted offline with @MichaelDeBoey, but just updating here too.

My feeling is that this is okay as a short-term fix since it's not changing any of the relationships between the packages — it's simply fixing an issue where @remix-run/react/package.json is out of sync with reality. I agree that it's a good idea to revisit the current architecture at some point, but I don't think it needs to hold up this fix in the meantime. We could duplicate the SerializeFrom type to avoid the server-runtime dependency, but I think that will make refactoring harder in the future, and including it as a dependency doesn't seem to have any down side from a consumer's perspective.

[pcattori]

My feeling is that this is okay as a short-term fix since it's not changing any of the relationships between the packages — it's simply fixing an issue where @remix-run/react/package.json is out of sync with reality. I agree that it's a good idea to revisit the current architecture at some point, but I don't think it needs to hold up this fix in the meantime. We could duplicate the SerializeFrom type to avoid the server-runtime dependency, but I think that will make refactoring harder in the future, and including it as a dependency doesn't seem to have any down side from a consumer's perspective.

I agree. Originally, the package reorg work was going to happen early this year, but we deprioritized it since it would be a breaking change, plus we wanted to focus on HMR/HDR work. Let's add @remix-run/server-runtime back as a dependency and we can clean it up when we tackle package reorg in v2.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-65fdbcd-20230815 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!