feat(remix-node): replace extended classes for NodeRequest
& NodeResponse
with interface type casts
#7109
+82
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retarget to dev of #7069, credit to @jeeyoungk
Closes #3480
Closes #4148
Closes #4395
Closes #7059
This is a fix for the referenced issue; The fix is by
NodeRequest
andNodeResponse
classes with interfaces.new NodeRequest
orx instanceof NodeRequest
). For this purpose,WebRequest
andWebResponse
are exposed as classes.This code is quite tricky as we're exporting types and values separately. The correct way of doing this is to define a type and value with the same identifier,
export
handles this correctly.Testing Strategy: new integration and unit tests