fix(dev): Silence ESM-only warning when building for ESM #6822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6766
When targeting ESM module format (like the default Express template does) with the configuration of
serverModuleFormat: "esm"
, there is no need to warn about ESM-only dependencies for the node server build.The current warning looks like this:
Testing Strategy:
I tested this change with ESM-only dependencies (
quick-lru
andbrowser-bunyan
) on the Remix Express template. There is now no warning output and the ESM-only module still works correctly (when removed fromserverDependenciesToBundle
).