Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev): warn if not using v2_dev #6818

Merged
merged 10 commits into from
Jul 13, 2023
Merged

chore(dev): warn if not using v2_dev #6818

merged 10 commits into from
Jul 13, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jul 12, 2023 •
edited
Loading

TODO

  • --manual + v2_dev.manual (undoc/warn for --no-restart and v2_dev.restart)
  • warn if not using v2_dev
  • changeset

Follow-on work

  • remix-serve compat with CJS --manual?
  • update templates
  • update tutorials

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d7ca51f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/v2-dev branch 7 times, most recently from 1c9e51d to 129d1bb Compare July 12, 2023 18:21
@mjackson
Copy link
Member

I don't think we need to undoc or warn if they use --no-restart. It's just an alias for the same thing, and could help some people understand what it does from a different angle. I like the fact that we have 2 flags for it.

@pcattori pcattori changed the title docs(guides/dev-perf): add dx guide for perf chore(dev): warn if not using v2_dev Jul 13, 2023
@pcattori pcattori marked this pull request as ready for review July 13, 2023 15:38
@pcattori pcattori merged commit 5a14105 into dev Jul 13, 2023
@pcattori pcattori deleted the pedro/v2-dev branch July 13, 2023 15:38
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 13, 2023
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed docs package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcattori @mjackson @brophdawg11