-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid circular references and infinitely recursive types #6736
Conversation
🦋 Changeset detectedLatest commit: 64988d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Bummer 😕 |
Yep, its too bad. You can do this in user-land via something like this, but that will expand things all the way down, which isn't great DX in many cases either. I wish there was some way to give hints to TS about which things to evaluate for displaying types and which things not too. Or like a way to click into types interactively to evaluate them on-demand for debugging purposes. |
I tried something in #6746 to fix this, maybe it can help! |
Fixes #6701 , #6693
Reverts "pretty" types for
useLoaderData
,useActionData
, etc...Pretty types relied on the ability to eagerly evaluate types, but this can cause infinite recursion or errors with circular referenced types.
Tested in Typescript playground
Also tested locally