-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dev): skip Remix/React packages in CSS build #6654
Conversation
🦋 Changeset detectedLatest commit: 817024f The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Hi. Just curious about the decision to exclude packages instead of creating a whitelist in remix.config. I'd assume we would just include |
@kiliman this was a way of improving perf without changing API. Though I personally agree that we should explore the approach you suggest as well. |
🤖 Hello there, We just published version Thanks! |
The CSS bundle build ultimately only cares CSS imports and these packages are known not to contain any, so this PR allows esbuild to skip compilation of these packages entirely. In my basic example app using CSS bundling, I've seen builds go from ~170ms to ~120ms.