Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use long version numbers #6551

Merged
merged 1 commit into from
Jun 8, 2023
Merged

chore: use long version numbers #6551

merged 1 commit into from
Jun 8, 2023

Conversation

MichaelDeBoey
Copy link
Member

This can prevent confusion like #6428 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: 6c223fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey requested a review from jacob-ebey June 6, 2023 22:33
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 6, 2023
Merged
@brophdawg11
Copy link
Contributor

Is this a common confusion? I would assume >=14 is interpreted as >=14.0.0

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 I would assume as well, but I've come across people that are confused about this already a couple of times now (all in different repo's), hence the update

@brophdawg11 brophdawg11 merged commit 72d7377 into remix-run:main Jun 8, 2023
@MichaelDeBoey MichaelDeBoey deleted the use-long-version-numbers-main branch June 8, 2023 13:36
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jul 11, 2023
Merged
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@machour machour Awaiting requested review from machour

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed docs template:architect template:cloudflare-pages template:cloudflare-workers template:deno template:express template:fly template:netlify template:remix template:vercel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @brophdawg11