Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CatchBoundary for v2 #5781

Merged
merged 11 commits into from
Mar 17, 2023
Merged

Remove CatchBoundary for v2 #5781

merged 11 commits into from
Mar 17, 2023

Conversation

brophdawg11
Copy link
Contributor

  • Removes CatchBoundary code for Remix v2
  • Removes v2_errorBoundary future flag
  • Removes V2_ prefix from V2_ErrorBoundary* types/components

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

🦋 Changeset detected

Latest commit: d8fa0b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Major
@remix-run/server-runtime Major
@remix-run/testing Major
@remix-run/cloudflare Major
@remix-run/deno Major
@remix-run/dev Major
@remix-run/node Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
create-remix Major
@remix-run/css-bundle Major
@remix-run/architect Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/vercel Major
@remix-run/serve Major
remix Major
@remix-run/eslint-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@chaance chaance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just a note about the docs (feel free to take it or leave it).

docs/route/error-boundary.md Outdated Show resolved Hide resolved
@brophdawg11 brophdawg11 force-pushed the brophdawg11/remove-catch-boundary branch from 82903ed to cb8c1ba Compare March 16, 2023 18:38
@brophdawg11 brophdawg11 merged commit b8e5eaa into v2 Mar 17, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-catch-boundary branch March 17, 2023 16:21
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Jul 9, 2023
MichaelDeBoey added a commit that referenced this pull request Jul 10, 2023
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@MichaelDeBoey MichaelDeBoey added the v2 Issues related to v2 apis label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants