fix(remix-server-runtime): don't use React types

[MichaelDeBoey]

Follow-up of #4801

Not the most ideal thing to do imo, but it fixes #5615 🤷‍♂️

As I mentioned in #4801 (comment), I added @types/react to dependencies because we're using ComponentType type in packages/remix-server-runtime/routeModules.ts

remix/packages/remix-server-runtime/routeModules.ts

Line 40 in 7935312

export type CatchBoundaryComponent = ComponentType;

remix/packages/remix-server-runtime/routeModules.ts

Line 45 in 7935312

export type ErrorBoundaryComponent = ComponentType<{ error: Error }>;

remix/packages/remix-server-runtime/routeModules.ts

Line 218 in 7935312

export type RouteComponent = ComponentType<{}>;

We should probably move that to @remix-run/react and make @remix-run/server-runtime more renderer-agnostic in that place.

@brophdawg11 thought that would be the case when moving to RR 6.4 (see #4801 (comment)), but apparently that's not the case 😢

---

Closes #5615
Closes #6275

[changeset-bot]

🦋 Changeset detected

Latest commit: cd1b030

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@remix-run/server-runtime	Patch
@remix-run/cloudflare	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
create-remix	Patch
@remix-run/architect	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/serve	Patch
@remix-run/testing	Patch
@remix-run/vercel	Patch
remix	Patch
@remix-run/css-bundle	Patch
@remix-run/eslint-config	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[brophdawg11]

Talked this over with @jacob-ebey and @pcattori and we decided that the loosening of the types in server-runtime is really just a bug fix since that should never have been exporting react-flavored types. We've included deprecation warnings pointing to the corresponding types in @remix-run/react.

[lpsinger]

Do I understand correctly based on the labels that this won't be fixed until v2? When will that be?

[brophdawg11]

@lpsinger Nah sorry for the confusion - we're going to get this merged for the next release

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-eb06147-20230614 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.17.1-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[brophdawg11]

Hm, we must have a bug in our bot logic - this is not included in 1.17.1-pre.1 and should land in 1.18.0

https://github.com/remix-run/remix/compare/remix@1.17.0...remix@1.17.1-pre.1

[mcansh]

Hm, we must have a bug in our bot logic - this is not included in 1.17.1-pre.1 and should land in 1.18.0

https://github.com/remix-run/remix/compare/remix@1.17.0...remix@1.17.1-pre.1

yeah that’s odd… it gets the commits via git log --pretty=format:%H v0.0.0-nightly-eb06147-20230614...remix@1.17.1-pre.1 ./packages, but seems like github actions got a different list 🤔

indeed not here, but somehow got into the list in ci

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-ad9adee-20230615 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-12440f3-20230616 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!