feat: prefetch link preloads #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiodxa
reviewed
Nov 24, 2021
packages/remix-react/links.ts
Outdated
| @@ -8,6 +8,7 @@ import type { RouteMatch } from "./routeMatching"; | |||
| // import { matchClientRoutes } from "./routeMatching"; | |||
| import type { RouteModules, RouteModule } from "./routeModules"; | |||
| import { loadRouteModule } from "./routeModules"; | |||
| import invariant from "./invariant"; | |||
ab9dac4 to
172ecc9
Compare
If a route exports `<link rel="preload">`, those are added as prefetches for `<Link prefetch>`. If the route says they are important enough to make high priority, then we can speed it up even more by prefetching before the user gets there. This enables routes to tell links to prefetch any kind of asset without the linking component needing to know.
b31ecf4 to
fe4d395
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a route exports
<link rel="preload">, those are added as prefetches for<Link prefetch>.If the route says they are important enough to make high priority when the route becomes active, then we can speed it up even more by prefetching before the user gets there.
This enables routes to tell links to prefetch any kind of asset without the linking component needing to know.