Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(remix-dev): flat routes perf improvements #5634

Merged
merged 13 commits into from
Mar 20, 2023
Merged

refactor(remix-dev): flat routes perf improvements #5634

merged 13 commits into from
Mar 20, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 2, 2023 •
edited
Loading

  • Stop glob matching for routes, instead fs.readdirSync() just the routes directory, and if (isDir) look for a index or route module.
  • Move away from define routes helper for something like this with a single iteration over routes sorted by reverse ID length

this is available as v0.0.0-experimental-699baf49c

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 5cff0a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh force-pushed the logan/flat-routes-perf branch 3 times, most recently from a2efde6 to 4731b15 Compare March 3, 2023 20:22
@mcansh mcansh mentioned this pull request Mar 6, 2023
Merged
2 tasks
@mcansh
first
9593297 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh marked this pull request as ready for review March 8, 2023 21:28
@mcansh @jacob-ebey
feat: flat routes perf improvements
b3b9896 
Signed-off-by: Logan McAnsh <logan@mcan.sh>

Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
@mcansh mcansh force-pushed the logan/flat-routes-perf branch 5 times, most recently from 917d73b to 00d1682 Compare March 9, 2023 02:28
@mcansh
chore: use relative path from appDirectory for collision files
b45d169 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/flat-routes-perf branch from 00d1682 to 7700efe Compare March 9, 2023 02:38
@mcansh
chore: rename a few things, make tests work on windows
7e0a4f4 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/flat-routes-perf branch 2 times, most recently from 3a036cc to a2af795 Compare March 9, 2023 19:12
mcansh added 5 commits March 9, 2023 14:46
@mcansh
test: add test to confirm ignoredRouteFiles still works
0644872 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
fix: normalize slashes
542a941 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: update test name
b9144af 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: normalize app directory
bb5ac71
@mcansh
normalize paths
2039bbd
@mcansh mcansh mentioned this pull request Mar 10, 2023
Merged
5 tasks
mcansh added 2 commits March 13, 2023 10:20
@mcansh
test: re-use variable
c692fc4 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use relative path when checking against ignoredFileRegex
4299d98 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/flat-routes-perf branch from 57b0e6e to 1c3c48f Compare March 14, 2023 19:51
mcansh added 2 commits March 14, 2023 16:14
@mcansh
test: update test
915bd94 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
test: move to e2e test as flatRoutesUniversal wants only route files
5cff0a4 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/flat-routes-perf branch 3 times, most recently from b6f8725 to 5cff0a4 Compare March 16, 2023 14:45
@mcansh mcansh linked an issue Mar 16, 2023 that may be closed by this pull request
incorrect warning about index routes having child routes #5828
Closed
@mcansh mcansh merged commit 4d86674 into dev Mar 20, 2023
@mcansh mcansh deleted the logan/flat-routes-perf branch March 20, 2023 21:01
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 20, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-4d86674-20230321 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@mcansh mcansh mentioned this pull request Mar 21, 2023
Merged
@mcansh mcansh mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees

@mcansh mcansh

@jacob-ebey jacob-ebey

Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect warning about index routes having child routes
3 participants
@mcansh @MichaelDeBoey @jacob-ebey