Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Component — renders an absolute URL as a relative href #5498

Closed
wants to merge 2 commits into from

Conversation

thomasverleye
Copy link
Contributor

@thomasverleye thomasverleye commented Feb 17, 2023

  • Docs
  • Tests

Testing Strategy:

run yarn bug-report-test

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023

⚠️ No Changeset found

Latest commit: 1cb4af5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 17, 2023

Hi @thomasverleye,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 17, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@thomasverleye thomasverleye marked this pull request as ready for review February 17, 2023 14:18
@thomasverleye thomasverleye changed the title Link Component — mailto: should stay mailto: as an absolute url Link Component — renders an absolute URL as a relative href Feb 19, 2023
@brophdawg11
Copy link
Contributor

Thanks @thomasverleye! I confirmed this is fixed if I update Remix to use react-router-dom@6.8.2-pre.1 which includes your fix over there. Since we've got it tested over in the router I'm going to close this out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants