Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: index route not detected if using folder #5495

Closed
wants to merge 2 commits into from

Conversation

suciptoid
Copy link

@suciptoid suciptoid commented Feb 17, 2023

Fix flat routes when using folder as _index/routes.jsx

Example:
Throw error: Path "/:invoice" defined by route "$invoice._index/route" conflicts with route "$invoice/route" with route :

/routes/$invoice/route.tsx <-- layout
/routes/$invoice/_index/route.tsx

also close this issue

Closes: #5490

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023

⚠️ No Changeset found

Latest commit: ef20baa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh
Copy link
Collaborator

mcansh commented Feb 17, 2023

thanks for the PR, this is resolved by #5459 :)

<Routes>
  <Route file="root.tsx">
    <Route path=":invoice" file="routes/$invoice/route.tsx">
      <Route index file="routes/$invoice/_index/route.tsx" />
    </Route>
  </Route>
</Routes>

image

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-aecf731-20230222 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@suciptoid suciptoid closed this Feb 22, 2023
@suciptoid suciptoid deleted the fix-index-route branch February 22, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants