Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix version script #4925

Merged
merged 1 commit into from
Jan 22, 2023
Merged

chore: fix version script #4925

merged 1 commit into from
Jan 22, 2023

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #4849

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f175449

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MichaelDeBoey
MichaelDeBoey commented Dec 20, 2022
View reviewed changes
scripts/utils.js
Comment on lines +104 to +115
let isRelaxedPeerDep =
config.peerDependencies[`@remix-run/${pkg}`]?.startsWith("^");
config.peerDependencies[`@remix-run/${pkg}`] = `${
isRelaxedPeerDep ? "^" : ""
}${nextVersion}`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaance loosened this in #4736 for @remix-run/dev

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll defer to @chaance on this :)

scripts/utils.js
Comment on lines +172 to +180
return remixPackagesFull.includes(packageName) &&
importName !== "@remix-run/deno"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remix-run/deno code is already a Deno module, so just get types for it directly from node_modules/

remix/templates/deno/.vscode/resolve_npm_imports.json

Lines 10 to 11 in d5ca496

"// `@remix-run/deno` code is already a Deno module, so just get types for it directly from `node_modules/`": "",
"@remix-run/deno": "../node_modules/@remix-run/deno/index.ts",

@MichaelDeBoey MichaelDeBoey force-pushed the fix-version-script branch 2 times, most recently from 9d85911 to bbf55c7 Compare December 21, 2022 18:41
@mcansh mcansh requested a review from chaance December 27, 2022 16:40
@MichaelDeBoey MichaelDeBoey force-pushed the fix-version-script branch 2 times, most recently from db318c2 to c952001 Compare January 21, 2023 14:22
@mcansh mcansh removed their assignment Jan 21, 2023
chaance
chaance reviewed Jan 21, 2023
View reviewed changes
scripts/utils.js Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey requested a review from chaance January 22, 2023 00:43
@chaance chaance merged commit bb50284 into remix-run:main Jan 22, 2023
@MichaelDeBoey MichaelDeBoey deleted the fix-version-script branch January 22, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh left review comments

@chaance chaance chaance approved these changes

Assignees

@chaance chaance

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @chaance @mcansh