Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(remix-testing): utilize react-router 6.5+ #4915

Merged
merged 9 commits into from
Dec 22, 2022
Merged

chore(remix-testing): utilize react-router 6.5+ #4915

merged 9 commits into from
Dec 22, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Dec 19, 2022 •
edited
Loading

supersedes #4899

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

Testing Strategy: https://github.com/mcansh/stubbbbbs

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 639c052

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
remix Patch
@remix-run/testing Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh changed the title chore: in progress updates to use react router instead of remix-run/r… chore: use react router instead of remix-run/router Dec 19, 2022
@mcansh mcansh force-pushed the logan/use-react-router-directly branch from d200972 to 38865c3 Compare December 20, 2022 22:31
@mcansh mcansh marked this pull request as ready for review December 20, 2022 23:18
@mcansh mcansh changed the title chore: use react router instead of remix-run/router chore(remix-testing): utilize react-router 6.5+ Dec 20, 2022
@mcansh mcansh mentioned this pull request Dec 20, 2022
Closed
1 task
@mcansh mcansh linked an issue Dec 20, 2022 that may be closed by this pull request
Update testing helpers to utilize React Router 6.4+ apis #4928
Closed
1 task
@mcansh mcansh mentioned this pull request Dec 21, 2022
Closed
2 tasks
mcansh added a commit that referenced this pull request Dec 21, 2022
@mcansh
chore(remix-dev): remove no longer used imports that made their way i…
2bc3d0c 
…n when this package was created in #4915

Signed-off-by: Logan McAnsh <logan@mcan.sh>
brophdawg11
brophdawg11 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete RemixEntry now too :)

@mcansh mcansh changed the base branch from dev to release-next December 21, 2022 20:09
@mcansh
Copy link
Collaborator Author

mcansh commented Dec 21, 2022

I think we can delete RemixEntry now too :)

removed that one here 2bc3d0c

@mcansh
chore: in progress updates to use react router instead of remix-run/r…
383f9d0 
…outer

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use memoryRouter
f2ad3b8 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use createMemoryRouter + RouterProvider
0d81122 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: memoize router
3c38b75 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
Create silver-ducks-protect.md
4ccacb6
@mcansh
chore(remix-testing): merge imports:
db374d6 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore(remix-dev): remove no longer used imports that made their way i…
5d25c61 
…n when this package was created in #4915

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: re-add RemixContext
6749331 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/use-react-router-directly branch from 8a7088c to 6749331 Compare December 22, 2022 15:25
@mcansh
chore: allow all properties on route
639c052 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh merged commit 722de31 into release-next Dec 22, 2022
@mcansh mcansh deleted the logan/use-react-router-directly branch December 22, 2022 15:43
This was referenced Dec 22, 2022
Closed
Merged
This was referenced Jan 9, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees
No one assigned
Labels
CLA Signed package:testing renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update testing helpers to utilize React Router 6.4+ apis
3 participants
@mcansh @brophdawg11 @MichaelDeBoey