Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api/conventions): mention actionHeaders in headers' arguments #3167

Merged
merged 5 commits into from
May 11, 2022

Conversation

nyarthan
Copy link
Contributor

  • Docs

Adds actionHeaders in the description and example of the headers Route Module API since they aren't mentioned in the documentation at all.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 11, 2022

Hi @Jannis-Morgenstern,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 11, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title chore(docs): reference actionHeaders of headers route module docs(api/conventions): mention actionHeaders in headers' arguments May 11, 2022
docs/api/conventions.md Outdated Show resolved Hide resolved
docs/api/conventions.md Outdated Show resolved Hide resolved
docs/api/conventions.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey merged commit 25c77a2 into remix-run:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants