Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): support JSX in .js route files #3059

Merged
merged 4 commits into from
May 3, 2022
Merged

fix(remix-dev): support JSX in .js route files #3059

merged 4 commits into from
May 3, 2022

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented May 2, 2022 •
edited
Loading

We currently support JSX syntax in .js files except for route modules. This PR should fix that.

  • Docs
  • Tests

@chaance chaance changed the title fix: support JSX in .js route files fix: Support JSX in .js route files May 2, 2022
@MichaelDeBoey MichaelDeBoey changed the title fix: Support JSX in .js route files fix(remix-dev): support JSX in .js route files May 2, 2022
@MichaelDeBoey MichaelDeBoey marked this pull request as draft May 2, 2022 12:46
MichaelDeBoey
MichaelDeBoey previously requested changes May 2, 2022
View reviewed changes
rollup.config.js Outdated Show resolved Hide resolved
@chaance chaance marked this pull request as ready for review May 2, 2022 13:24
@chaance @MichaelDeBoey
Update rollup.config.js
c135bef 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
chaance
chaance commented May 2, 2022
View reviewed changes
integration/js-routes-test.ts
@@ -0,0 +1,42 @@
import { test } from "@playwright/test";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went to add a unit test to our build in remix-dev but it looks like that test is completely skipped and relies on the old Gists app that no longer exists. I tried to adapt it with a new fixture but couldn't get it working, so I went with this for now. We should probably fix that test file though.

@chaance chaance mentioned this pull request May 2, 2022
Merged
@chaance chaance merged commit 8c40933 into dev May 3, 2022
@chaance chaance deleted the chance/jsx-in-js branch May 3, 2022 14:47
@brophdawg11 brophdawg11 mentioned this pull request May 3, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-fd210bf-20220504 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-b797f54-20220505 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-b797f54-20220506 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 10, 2022
@chaance @aaronpowell
fix(remix-dev): support JSX in .js route files (remix-run#3059)
372ff69
christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 16, 2022
@chaance
fix(remix-dev): support JSX in .js route files (remix-run#3059)
ceb9db2
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaance @MichaelDeBoey @mcansh