Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: nested <p> tag in another <p> in a couple of examples #535

Closed
12 tasks
arpitdalal opened this issue Nov 23, 2021 · 3 comments
Closed
12 tasks

[Bug]: nested <p> tag in another <p> in a couple of examples #535

arpitdalal opened this issue Nov 23, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@arpitdalal
Copy link

Which Remix packages are impacted?

  • remix (Remix core)
  • create-remix
  • @remix-run/architect
  • @remix-run/cloudflare-workers
  • @remix-run/dev
  • @remix-run/express
  • @remix-run/netlify
  • @remix-run/node
  • @remix-run/react
  • @remix-run/serve
  • @remix-run/server-runtime
  • @remix-run/vercel

What version of Remix are you using?

1.0.4

Steps to Reproduce

In the examples/basic and examples/blog-tutorial

  1. run application on the dev server
  2. open console from devtools
  3. visit any one of these routes localhost:3000/demos/params/shh-its-a-secret or localhost:3000/demos/params/this-record-does-not-exist

Expected Behavior

No errors in the console other than HTTP errors such as 401 and 404

Actual Behavior

A warning saying that <p> should not be nested into another <p>

Exact warning:
Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.

@arpitdalal arpitdalal added the bug Something isn't working label Nov 23, 2021
@arpitdalal
Copy link
Author

closed in #533

@arpitdalal
Copy link
Author

Actually, #533 only partially fixes it. #533 doesn't fix the blog-tutorial example

@ryanflorence
Copy link
Member

Thank you for your help, but it looks like we've already fixed this.

If I'm wrong, please re-open this issue and we'll get it sorted out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants