Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Demo - URL Params and Error Boundaries - Nested <p> console error in CatchBoundary #532

Closed
1 of 12 tasks
joshuadotson opened this issue Nov 23, 2021 · 1 comment · May be fixed by Varedis/remix#23
Closed
1 of 12 tasks
Labels
bug Something isn't working

Comments

@joshuadotson
Copy link

Which Remix packages are impacted?

  • remix (Remix core)
  • create-remix
  • @remix-run/architect
  • @remix-run/cloudflare-workers
  • @remix-run/dev
  • @remix-run/express
  • @remix-run/netlify
  • @remix-run/node
  • @remix-run/react
  • @remix-run/serve
  • @remix-run/server-runtime
  • @remix-run/vercel

What version of Remix are you using?

1.0.4

Steps to Reproduce

  • nav to ./examples/basic
  • install dependencies npm i
  • start dev server npm dev
  • open http://localhost:3000/
  • choose URL Params and Error Boundaries under Demos In This App
  • open dev tools console
  • select This will be a 404 under Click these Links
  • observe error in console

Expected Behavior

No error occurs because the HTML structure is valid.

Actual Behavior

Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.

Above error occurs because the HTML structure is not valid.

@machour
Copy link
Collaborator

machour commented Mar 18, 2022

Fixed in #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants