test(dev): cross-env for NODE_ENV on windows

remix-run · Feb 22, 2023 · 7068fae · 7068fae
1 parent 8f60539
commit 7068fae
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/integration/hmr-test.ts b/integration/hmr-test.ts
@@ -21,12 +21,13 @@ let fixture = (options: { port: number; appServerPort: number }) => ({
           "private": true,
           "sideEffects": false,
           "scripts": {
-            "dev:remix": "NODE_ENV=development node ./node_modules/@remix-run/dev/dist/cli.js dev",
-            "dev:app": "NODE_ENV=development nodemon --watch build/ ./server.js"
+            "dev:remix": "cross-env NODE_ENV=development node ./node_modules/@remix-run/dev/dist/cli.js dev",
+            "dev:app": "cross-env NODE_ENV=development nodemon --watch build/ ./server.js"
           },
           "dependencies": {
             "@remix-run/node": "0.0.0-local-version",
             "@remix-run/react": "0.0.0-local-version",
+            "cross-env": "0.0.0-local-version",
             "express": "0.0.0-local-version",
             "isbot": "0.0.0-local-version",
             "nodemon": "0.0.0-local-version",

diff --git a/package.json b/package.json
@@ -95,6 +95,7 @@
     "chalk": "^4.1.2",
     "cheerio": "^1.0.0-rc.3",
     "concurrently": "^7.0.0",
+    "cross-env": "^7.0.3",
     "cross-spawn": "^7.0.3",
     "cypress": "^9.6.0",
     "eslint": "^8.23.1",

diff --git a/yarn.lock b/yarn.lock
@@ -4957,6 +4957,13 @@ core-util-is@1.0.2, core-util-is@~1.0.0:
   resolved "https://registry.npmjs.org/core-util-is/-/core-util-is-1.0.2.tgz"
   integrity sha1-tf1UIgqivFq1eqtxQMlAdUUDwac=
 
+cross-env@^7.0.3:
+  version "7.0.3"
+  resolved "https://registry.npmjs.org/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
+  integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
+  dependencies:
+    cross-spawn "^7.0.1"
+
 cross-spawn@^5.1.0:
   version "5.1.0"
   resolved "https://registry.npmjs.org/cross-spawn/-/cross-spawn-5.1.0.tgz"
@@ -4977,7 +4984,7 @@ cross-spawn@^6.0.5:
     shebang-command "^1.2.0"
     which "^1.2.9"
 
-cross-spawn@^7.0.0, cross-spawn@^7.0.2, cross-spawn@^7.0.3:
+cross-spawn@^7.0.0, cross-spawn@^7.0.1, cross-spawn@^7.0.2, cross-spawn@^7.0.3:
   version "7.0.3"
   resolved "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz"
   integrity sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==