chore: give integration tests a real version

Signed-off-by: Logan McAnsh <logan@mcan.sh>
remix-run · Mar 6, 2023 · 56c3868 · 56c3868
1 parent b635550
commit 56c3868
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 11 deletions.
diff --git a/integration/cf-compiler-test.ts b/integration/cf-compiler-test.ts
@@ -23,7 +23,7 @@ test.describe("cloudflare compiler", () => {
             "@remix-run/react": "0.0.0-local-version",
             isbot: "0.0.0-local-version",
             react: "0.0.0-local-version",
-            "react-dom": "0.0.0-local-version",
+            "react-dom": "^18.2.0",
             "worker-pkg": "0.0.0-local-version",
             "browser-pkg": "0.0.0-local-version",
             "esm-only-pkg": "0.0.0-local-version",

diff --git a/integration/deno-compiler-test.ts b/integration/deno-compiler-test.ts
@@ -44,7 +44,7 @@ test.beforeAll(async () => {
           "@remix-run/react": "0.0.0-local-version",
           isbot: "0.0.0-local-version",
           react: "0.0.0-local-version",
-          "react-dom": "0.0.0-local-version",
+          "react-dom": "^18.2.0",
           component: "0.0.0-local-version",
           "deno-pkg": "0.0.0-local-version",
         },

diff --git a/integration/esm-only-warning-test.ts b/integration/esm-only-warning-test.ts
@@ -26,7 +26,7 @@ test.beforeAll(async () => {
           "@remix-run/serve": "0.0.0-local-version",
           isbot: "0.0.0-local-version",
           react: "0.0.0-local-version",
-          "react-dom": "0.0.0-local-version",
+          "react-dom": "^18.2.0",
           "esm-only-no-exports": "0.0.0-local-version",
           "esm-only-exports": "0.0.0-local-version",
           "esm-only-sub-exports": "0.0.0-local-version",

diff --git a/integration/helpers/cf-template/package.json b/integration/helpers/cf-template/package.json
@@ -9,8 +9,8 @@
     "@remix-run/cloudflare-workers": "0.0.0-local-version",
     "@remix-run/react": "0.0.0-local-version",
     "isbot": "0.0.0-local-version",
-    "react": "0.0.0-local-version",
-    "react-dom": "0.0.0-local-version"
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0"
   },
   "devDependencies": {
     "@cloudflare/workers-types": "0.0.0-local-version",

diff --git a/integration/helpers/deno-template/package.json b/integration/helpers/deno-template/package.json
@@ -6,8 +6,8 @@
     "@remix-run/deno": "0.0.0-local-version",
     "@remix-run/react": "0.0.0-local-version",
     "isbot": "0.0.0-local-version",
-    "react": "0.0.0-local-version",
-    "react-dom": "0.0.0-local-version"
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0"
   },
   "devDependencies": {
     "@remix-run/dev": "0.0.0-local-version"

diff --git a/integration/helpers/node-template/package.json b/integration/helpers/node-template/package.json
@@ -12,8 +12,8 @@
     "@remix-run/react": "0.0.0-local-version",
     "@remix-run/serve": "0.0.0-local-version",
     "isbot": "0.0.0-local-version",
-    "react": "0.0.0-local-version",
-    "react-dom": "0.0.0-local-version"
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0"
   },
   "devDependencies": {
     "@remix-run/dev": "0.0.0-local-version",

diff --git a/integration/hmr-test.ts b/integration/hmr-test.ts
@@ -32,8 +32,8 @@ let fixture = (options: { port: number; appServerPort: number }) => ({
             "express": "0.0.0-local-version",
             "isbot": "0.0.0-local-version",
             "nodemon": "0.0.0-local-version",
-            "react": "0.0.0-local-version",
-            "react-dom": "0.0.0-local-version",
+            "react": "^18.2.0",
+            "react-dom": "^18.2.0",
             "tailwindcss": "0.0.0-local-version"
           },
           "devDependencies": {

diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts
@@ -461,6 +461,7 @@ export async function readConfig(
   let pkgJson = await NPMCliPackageJson.load(remixRoot);
   let deps = pkgJson.content.dependencies ?? {};
 
+  // TODO: check for experimental releases
   let reactVersion = lte(deps.react, "18.0.0") ? "17" : "18";
   if (!reactVersion) {
     let react = ["react", "react-dom"];