chore: have eslint report unused eslint comments (#4863)

* chore: have eslint report unused eslint comments

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* chore: remove additional comment

Signed-off-by: Logan McAnsh <logan@mcan.sh>

.eslintignore

@@ -1,11 +1,11 @@
 **/build/
 **/tests/__snapshots/
 **/node_modules/
-!.eslintrc.js
 .tmp
 /playground
 **/__tests__/fixtures
 **/__tests__/**/*/fixtures
+/packages/*/dist/
 
 # Deno
 integration/helpers/deno-template

.eslintrc.js

@@ -24,4 +24,8 @@ module.exports = {
       },
     },
   ],
+  // Report unused `eslint-disable` comments.
+  reportUnusedDisableDirectives: true,
+  // Tell ESLint not to ignore dot-files, which are ignored by default.
+  ignorePatterns: ["!.*.js"],
 };

package.json

@@ -29,7 +29,7 @@
     "format": "prettier --ignore-path .eslintignore --write ./ && npm run lint:fix",
     "format:deno": "deno fmt integration/helpers/deno-template packages/remix-deno templates/deno --ignore=packages/remix-deno/node_modules",
     "license": "node ./scripts/license.js",
-    "lint": "eslint --cache --ext .tsx,.ts,.js,.jsx,.md .",
+    "lint": "eslint --cache .",
     "lint:deno": "deno lint integration/helpers/deno-template packages/remix-deno templates/deno --ignore=packages/remix-deno/node_modules",
     "lint:fix": "yarn lint --fix",
     "playground:new": "node ./scripts/playground/new.js",

packages/remix-react/__tests__/hook-types-test.tsx

@@ -6,8 +6,6 @@ function isEqual<A, B>(
   arg: A extends B ? (B extends A ? true : false) : false
 ): void {}
 
-// not sure why `eslint` thinks the `T` generic is not used...
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 type LoaderData<T> = ReturnType<typeof useLoaderData<T>>;
 
 describe("useLoaderData", () => {

packages/remix-server-runtime/rollup.config.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-restricted-globals, import/no-nodejs-modules */
+/* eslint-disable import/no-nodejs-modules */
 const path = require("path");
 const babel = require("@rollup/plugin-babel").default;
 const nodeResolve = require("@rollup/plugin-node-resolve").default;

packages/remix/rollup.config.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies */
 const babel = require("@rollup/plugin-babel").default;
 const path = require("path");