Update descendant routes warning message #8202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I’d definitely support adding some inline snapshot tests of the two different cases. Would you like to add that to this PR @msutkowski ? |
Will do! I'll tack that on shortly. |
msutkowski
commented
Nov 4, 2021
packages/react-router/__tests__/descendant-routes-warning-test.tsx
Outdated
Show resolved
Hide resolved
mjackson
reviewed
Nov 5, 2021
| expect(consoleWarn.mock.calls[0][0]) | ||
| .toMatch(`You rendered descendant <Routes> (or called \`useRoutes()\`) at "/" (under <Route path="/">) but the parent route path has no trailing "*". This means if you navigate deeper, the parent won't match anymore and therefore the child routes will never render. | ||
|
|
||
| Please change the parent <Route path="/"> to <Route path="/*">.`); |
There was a problem hiding this comment.
Let's just tell them to use <Route path="*"> instead of <Route path="/*">.
packages/react-router/__tests__/descendant-routes-warning-test.tsx
Outdated
Show resolved
Hide resolved
05b3b52 to
a43e627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly modifies the error message for silly people like me that might see this, which would also be an error:
This would show if you were in the middle of a v5->6 migration and had this:
As an aside, it might make sense to do
toMatchInlineSnapshotchecks of theconsoleWarnin the test to cover both of these cases.