Add ignoreScrollBehavior to new API #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68fbbfb to
a505143
Compare
|
Just added the new tests. One last thing I'd like to do in this PR is to incorporate changes I made in #477. |
|
@gaearon This looks great! Thank you. I'll wait until you're ready to merge. |
Previously, the only way to opt out of scroll updates for a route would be by using `ignoreScrollBehavior`. This, however, made it hard to implement arguably the most common use case: resetting scroll when `params` change and preserving it when only `query` changes. This commit completely disables scroll updates when only `query` has changed. This provides a reasonable default behavior and leaves `ignoreScrollBehavior` for more complicated cases. If you'd rather keep the old behavior and reset scroll on query changes, you can either promote `query` variables to be route `params` or reset scroll position yourself in response to `query` changes in route handler's `componentDidUpdate`. Fixes remix-run#432, remix-run#439
83125d6 to
5fe6c08
Compare
|
@mjackson Consider this one ready. |
|
Let's hold this off for a moment. I think there's a bug in current RR scrolling code, I might fix it here as well. |
|
Nevermind, this code is fine. The issue I'm experiencing is unrelated so let's bring this in. |
mjackson
added a commit
that referenced
this pull request
Nov 26, 2014
Add ignoreScrollBehavior to new API
|
Thanks @gaearon ! @rpflorence Let's cut a new release with this stuff. 0.12? |
|
@gaearon By all means, be my guest ;) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
ImitateBrowserBehaviorandScrollToTopBehaviorand reintroducesignoreScrollBehaviorwhich allows you to opt out of scrolling changes within bounds of some ancestor route.This was already implemented in #388 but it is missing in new API so I'm reimplementing it.
This PR adds test for
ScrollToTopBehaviorbut lacks tests forignoreScrollBehavior. I'll add these shortly.