Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve location.key only if it was present in the original input object #4109

Closed

Conversation

jochenberger
Copy link
Contributor

Don't add key: undefined to the location if the input does not have a location key.
See 90d4832, #3956

Copy link
Member

@timdorr timdorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdorr timdorr modified the milestone: v4.0.0 Oct 27, 2016
@timdorr timdorr added the bug label Oct 27, 2016
@jochenberger
Copy link
Contributor Author

What's keeping this from being merged? It blocks #4107 and #4106. Can I do something to help?

@timdorr
Copy link
Member

timdorr commented Nov 16, 2016

@ryanflorence needs to take a look at it. He and I are both terribly busy, so our bandwidth is limited. It's a people problem, not a code problem :)

@mjackson
Copy link
Member

This PR is outdated now. Thanks for the contribution, @jochenberger. It was just a little too early :)

@mjackson mjackson closed this Jan 11, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants