-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add react-router-devtools #80
base: main
Are you sure you want to change the base?
Conversation
Seems reasonable to me @arslan2012 will you rebase and run Also, if you or anyone is interested in actually hooking up react-router-devtools by default, I think that'd be a cool alternative |
Okay, I hooked up react-router-devtools to most of them, but there's two of them that I didn't
@brookslybrand Any suggestions? |
Awesome, thanks @arslan2012!
|
Hmmm, kind of weird that including @pcattori if you have a second to look at it that'd be cool, but all good if not |
@brookslybrand so the reason this happens is because some of the depenendencies need to be optimized to work on cloudflare, as per the docs: |
Yes, this is also kinda mentioned in react dev tools docs, but when I add them to vite.config
I get
|
normally if you're using react-router-devtools, you should also add it to your vite.config, but it's not present there
And also only the default template has this dependency, so I think this might be mistakenly added