Merge pull request #902 from remix-run/jacob/rem-473-redirects-after-…

…action-are-persisting fix: search params persisting on redirects
remix-run · Nov 1, 2021 · 2d5c85e · 2d5c85e
2 parents bb756f4 + 3095a04
commit 2d5c85e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/history/__tests__/TestSequences/ReplaceNewLocation.js b/packages/history/__tests__/TestSequences/ReplaceNewLocation.js
@@ -20,6 +20,17 @@ export default (history, done) => {
         state: null,
         key: expect.any(String)
       });
+
+      history.replace('/');
+    },
+    ({ action, location }) => {
+      expect(action).toBe('REPLACE');
+      expect(location).toMatchObject({
+        pathname: '/',
+        search: '',
+        state: null,
+        key: expect.any(String)
+      });
     }
   ];
 

diff --git a/packages/history/index.ts b/packages/history/index.ts
@@ -1051,7 +1051,9 @@ export function createPath({
  * @see https://github.com/ReactTraining/history/tree/master/docs/api-reference.md#parsepath
  */
 export function parsePath(path: string) {
-  let partialPath: PartialPath = {};
+  let partialPath: PartialPath = {
+    search: ''
+  };
 
   if (path) {
     let hashIndex = path.indexOf('#');