-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ScenarioMIP config files in line with internal protocol v4 #1920
Conversation
For transparency, here is a comparison of default ScenarioMIP scenarios with default REMIND scenarios:
|
@dklein-pik : This fixes the problem in the coupling tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for scenario_config_coupled_ScenarioMIP.csv
Column config/scenario_config.csv
|rcpXpX
is not needed and can be safely removed.
We don't use climate change impacts in the ScenarioMIP runs. This is set by nocc_hist
. Setting an addtional rcpXpX
impact pathway is confusing.
Column no_ghgprices_land_until
SMIPv04-VLHO-SSP2-EcBudg400-def has y2035
. Why 2035 and not 2030?
Everything else looks fine
Because we fix the scenario to the Medium scenario in 2030. REMIND |
Summary of exchange with @dklein-pik and @flohump :
For coupling configs, this implies:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scenario_config_coupled looks now fine from MAgPIE side
- introduce startgroup "remindinput" for scenarios that are required to update MAgPIE intputs in REMIND - remove choice of impact scenarios for MAgPIE, because climate change impacts are switches off by `nocc_hist` (see remindmodel#1920 (review))
Purpose of this PR
Update ScenarioMIP config files (REMIND standalone and coupling) according to Internal scenario protocol (v4) - ScenarioMIP main phase
Type of change
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly