Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selectPlots output script #1815

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 6, 2024

Purpose of this PR

  • add a new output scripts that is a bit like compareScenarios2, but interactive.
  • It is called via output.R -> comparison -> selectPlots.
  • It allows the user to select line and area plots to be collected in a pdf file in output/plots.
  • This allows to generate plots yet missing in compareScenarios, or with different bar plot years, or not create the whole 800 pages document if you just need a few plots
  • The user can select regions, periods and bar plot years to be used. Another option is whether the difference to one of the scenarios should be plotted.
  • For more details, see piamInterfaces::plotIntercomparison description.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test): [ FAIL 0 | WARN 0 | SKIP 6 | PASS 90 ]
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonds like a nice feature, thanks!

@orichters orichters merged commit 901412f into remindmodel:develop Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants