Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

#103 Create roles with no policies #106

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Conversation

aarcro
Copy link
Contributor

@aarcro aarcro commented May 8, 2017

Simple solution that can create roles. Other blueprints will have to attach policies as needed.

@phobologic
Copy link
Contributor

Have you found that creating roles with specific names is the pattern you follow? We tend to let AWS name our roles for us, and then make sure they are exported. The big reason for this is that whenever you use a *Name attribute in cloudformation, it comes with the caveat that you can't ever do an operation that results in a replacement of that resource, which can lead to a lot of pain in the future.

@aarcro
Copy link
Contributor Author

aarcro commented May 18, 2017

I don't require specifically named Roles. I just couldn't workout at the time how to create a role at all.

This isn't setting RoleName, so I don't think that's an issue here, right?

@phobologic
Copy link
Contributor

Hey @aarcro - I went ahead and fixed the pep8 error that was in this (long line) and made a small modification to allow the subclassing of this blueprint & overriding a method to generate statements which get attached to a policy.

Thanks for the PR!

@phobologic phobologic merged commit 8a5b2a5 into remind101:master Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants