Skip to content

Commit

Permalink
abandon this idea of depending workflows
Browse files Browse the repository at this point in the history
Even while making this work, it hides the dependancy to a commit / MR
  • Loading branch information
remi-dupre committed Dec 26, 2024
1 parent 3d10e0d commit 71fd712
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: checks
name: Checks

on:
- push
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
name: deploy-docs
name: Deploy Docs

on:
workflow_run:
workflows: [checks]
types:
- completed
- push

jobs:
deploy-python-doc:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/deploy-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@
#
# maturin generate-ci github
#
name: deploy-pypi
name: Deploy PyPI

on:
workflow_run:
workflows: [checks]
types:
- completed
- push

permissions:
contents: read
Expand Down Expand Up @@ -152,7 +149,7 @@ jobs:
release:
name: Release
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' && github.ref == 'refs/heads/master' }}
if: ${{ github.ref == 'refs/heads/master' }}
needs: [linux, musllinux, windows, macos, sdist]
permissions:
# Use to sign the release artifacts
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/deploy-rust.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
name: deploy-rust
name: Deploy Crates

on:
workflow_run:
workflows: [checks]
types:
- completed
- push

jobs:
deploy-rust:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}

strategy:
max-parallel: 1
Expand Down

0 comments on commit 71fd712

Please sign in to comment.