Merge branch 'main' into feat/add-scope-test

remcolakens · Jan 30, 2025 · 9da8ec5 · 9da8ec5
2 parents 4494a13 + 18cf12e
commit 9da8ec5
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -28,7 +28,10 @@ jobs:
           max_timeout: 600
 
   test_e2e:
+    name: Test e2e
     runs-on: ubuntu-latest
+    container:
+      image: mcr.microsoft.com/playwright:v1.50.0-noble
     needs: test_setup
     timeout-minutes: 60
     steps:
@@ -38,16 +41,14 @@ jobs:
       - name: Setup
         uses: ./.github/actions/setup
 
-      - name: Install Playwright browsers
-        run: pnpm exec playwright install --with-deps
-
       - name: Run tests
         run: pnpm test:e2e
         env:
           PLAYWRIGHT_TEST_BASE_URL: ${{ needs.test_setup.outputs.preview_url }}
+          HOME: /root
 
       - name: Upload test results
-        if: always() && !cancelled()
+        if: ${{ !cancelled() }}
         uses: actions/upload-artifact@v4
         with:
           name: playwright-test-results