Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to correctly compile intrinsic types #638

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Fix to correctly compile intrinsic types #638

merged 4 commits into from
Aug 26, 2021

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Aug 25, 2021 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 25, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy mentioned this pull request Aug 25, 2021
Closed
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 👶 semver/patch This is a backwards-compatible fix labels Aug 25, 2021
ChristianMurphy
ChristianMurphy commented Aug 25, 2021
View reviewed changes
remcohaszing
remcohaszing reviewed Aug 25, 2021
View reviewed changes
@ChristianMurphy @remcohaszing
types: refactor to use component type and remove key
f824c9c 
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
@ChristianMurphy ChristianMurphy mentioned this pull request Aug 26, 2021
Merged
5 tasks
wooorm
wooorm reviewed Aug 26, 2021
View reviewed changes
@casperiv0 casperiv0 mentioned this pull request Aug 26, 2021
Merged
5 tasks
@ChristianMurphy ChristianMurphy requested a review from wooorm August 26, 2021 13:24
@wooorm wooorm changed the title types: update to match new hast types, correctly compile intrinsics Fix to correctly compile intrinsic types Aug 26, 2021
@wooorm wooorm merged commit 5af6bc7 into remarkjs:main Aug 26, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 26, 2021
@ChristianMurphy ChristianMurphy deleted the fix-typings branch August 26, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@wooorm wooorm wooorm approved these changes

@Murderlon Murderlon Awaiting requested review from Murderlon

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristianMurphy @codecov-commenter @remcohaszing @wooorm