Skip to content

Commit

Permalink
Add warning when github.web and github.assets are both set (closes #836)
Browse files Browse the repository at this point in the history
  • Loading branch information
webpro committed Jan 15, 2022
1 parent 616525f commit 9e72c16
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/plugin/github/GitHub.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class GitHub extends Release {
async init() {
await super.init();

const { skipChecks, tokenRef, web, update } = this.options;
const { skipChecks, tokenRef, web, update, assets } = this.options;

if (!this.token || web) {
if (!web) {
Expand All @@ -48,6 +48,10 @@ class GitHub extends Release {
return;
}

if (web && assets) {
this.log.warn('Assets are not included in web-based releases.');
}

if (!skipChecks) {
// If we're running on GitHub Actions, we can skip the authentication and
// collaborator checks. Ref: https://bit.ly/2vsyRzu
Expand Down

0 comments on commit 9e72c16

Please sign in to comment.