Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds close() to dbs #142

Merged
merged 1 commit into from
Mar 27, 2025
Merged

adds close() to dbs #142

merged 1 commit into from
Mar 27, 2025

Conversation

leo-lox
Copy link
Contributor

@leo-lox leo-lox commented Mar 26, 2025

adds a close() to the cache manager, used to enable closing the database.
Needed to close db in a bg thread

adds attach to objectbox constructor

@leo-lox leo-lox self-assigned this Mar 26, 2025
@leo-lox leo-lox requested a review from frnandu March 26, 2025 17:10
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (1551772) to head (e0eae2a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../repositories/cache_manager/mem_cache_manager.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   72.01%   72.00%   -0.02%     
==========================================
  Files         113      113              
  Lines        3849     3850       +1     
==========================================
  Hits         2772     2772              
- Misses       1077     1078       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@frnandu frnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@leo-lox leo-lox merged commit e0824fe into master Mar 27, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants