fix(filter): Skip modules that do not belong to any chunk

relative-ci · Oct 11, 2023 · 5418a1c · 5418a1c
1 parent 98e97e8
commit 5418a1c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/packages/plugin-webpack-filter/src/index.ts b/packages/plugin-webpack-filter/src/index.ts
@@ -101,6 +101,11 @@ export default (
           (chunkId) => chunkId !== null && typeof chunkId !== 'undefined',
         ) || [];
 
+      // Skip modules that do not belong to any chunk
+      if (moduleChunks.length === 0) {
+        return agg;
+      }
+
       const concatenatedModules = moduleStats.modules?.reduce(
         (aggConcatenatedModules, concatenatedModule) => {
           if (!concatenatedModule.name) {

diff --git a/packages/utils/__fixtures__/webpack-stats-1.extracted.js b/packages/utils/__fixtures__/webpack-stats-1.extracted.js
@@ -39,11 +39,6 @@ module.exports = {
       name: 'module-b',
       size: 2000,
     },
-    {
-      chunks: [],
-      name: 'module-c',
-      size: 1000,
-    },
     {
       chunks: [1],
       name: 'node_modules/package-a/index.js',

diff --git a/packages/utils/src/jobs/__tests__/__snapshots__/create-job.ts.snap b/packages/utils/src/jobs/__tests__/__snapshots__/create-job.ts.snap
@@ -277,11 +277,6 @@ exports[`createJob no baseline 1`] = `
           "name": "module-b",
           "size": 2000,
         },
-        {
-          "chunks": [],
-          "name": "module-c",
-          "size": 1000,
-        },
         {
           "chunks": [
             1,
@@ -656,11 +651,6 @@ exports[`createJob with baseline 1`] = `
           "name": "module-b",
           "size": 2000,
         },
-        {
-          "chunks": [],
-          "name": "module-c",
-          "size": 1000,
-        },
         {
           "chunks": [
             1,