Skip to content

Commit

Permalink
refactor(utils): createJob - update job structure
Browse files Browse the repository at this point in the history
- flatten webpack.stats
- namespace meta, warnings
  • Loading branch information
vio committed Feb 29, 2020
1 parent fb113f3 commit 13d65a7
Show file tree
Hide file tree
Showing 25 changed files with 4,647 additions and 4,712 deletions.
7 changes: 4 additions & 3 deletions packages/bundle-stats/src/webpack-plugin.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import path from 'path';
import process from 'process';
import { get, merge } from 'lodash';
import { createJobs, extractDataFromWebpackStats } from '@bundle-stats/utils';
import { createJobs } from '@bundle-stats/utils';
import { filter } from '@bundle-stats/utils/lib-esm/webpack';

import * as TEXT from './text';
import { getBaselineStatsFilepath, readBaseline } from './baseline';
Expand Down Expand Up @@ -34,7 +35,7 @@ const getOnEmit = (options) => async (compilation, callback) => {
stats: statsOptions,
} = options;

const data = extractDataFromWebpackStats(
const data = filter(
compilation.getStats().toJson(statsOptions),
);

Expand All @@ -55,7 +56,7 @@ const getOnEmit = (options) => async (compilation, callback) => {
try {
if (compare) {
baselineStats = await readBaseline();
baselineStats = extractDataFromWebpackStats(baselineStats);
baselineStats = filter(baselineStats);
logger.info(`Read baseline from ${baselineFilepath}`);
}
} catch (err) {
Expand Down
4 changes: 2 additions & 2 deletions packages/html-templates/src/app/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ const StandaloneApp = ({ jobs }) => {
showSummaryItemBaselineValue={jobs.length !== 1}
/>
</Container>
{warnings && warnings.duplicatePackages && (
{warnings && warnings.webpack && warnings.webpack.duplicatePackages && (
<Container>
<DuplicatePackagesWarning duplicatePackages={warnings.duplicatePackages} />
<DuplicatePackagesWarning duplicatePackages={warnings.webpack.duplicatePackages} />
</Container>
)}
<Container>
Expand Down
12 changes: 5 additions & 7 deletions packages/html-templates/src/app/stories.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@ import baselineData from 'Fixtures/job.baseline.json'; // eslint-disable-line
import StandaloneApp from '.';

const JOBS = createJobs([
{ webpack: { stats: currentData.rawData.webpack.stats } },
{ webpack: { stats: baselineData.rawData.webpack.stats } },
{ webpack: currentData.rawData.webpack.stats },
{ webpack: baselineData.rawData.webpack.stats },
{
webpack: {
stats: {
...baselineData.rawData.webpack.stats,
assets: baselineData.rawData.webpack.stats.assets.filter((asset) => asset.name.match(/.(css|js)$/)),
modules: baselineData.rawData.webpack.stats.modules.slice(0, 100),
},
...baselineData.rawData.webpack.stats,
assets: baselineData.rawData.webpack.stats.assets.filter((asset) => asset.name.match(/.(css|js)$/)),
modules: baselineData.rawData.webpack.stats.modules.slice(0, 100),
},
},
]);
Expand Down
2 changes: 0 additions & 2 deletions packages/ui/__mocks__/job.baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"internalBuildNumber": 123,
"rawData": {
"webpack": {
"stats": {
"assets": [
{
"name": "../artifacts/webpack.json",
Expand Down Expand Up @@ -4370,7 +4369,6 @@
]
}
]
}
}
}
}
Loading

0 comments on commit 13d65a7

Please sign in to comment.