Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level for exceptions rescued by Rails #179

Merged
merged 11 commits into from
Sep 29, 2024

Conversation

tycooon
Copy link
Contributor

@tycooon tycooon commented Feb 15, 2023

The original version is skipping the log if the exception is rescued by Rails. I decided to still log those exceptions but with lower level (debug instead of fatal). I think this is still better than the current behavior.

@reidmorrison
Copy link
Owner

Looks like the rescue_response? code was added as of Rails 7, how will this work with Rails 5 & 6?

@tycooon
Copy link
Contributor Author

tycooon commented Mar 28, 2023

You are correct. I guess I can throw in a wrapper.respond_to?(:rescue_response?) check if that would be OK.

@tycooon
Copy link
Contributor Author

tycooon commented Sep 16, 2024

@reidmorrison updated :)

@reidmorrison reidmorrison merged commit fb9bd70 into reidmorrison:master Sep 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants