-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add crates.io as a source for auto version bump #3008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment above.
This reverts commit d76d2fb.
Head branch was pushed to by a user without write access
Fixed the failing test and added a full integration test for the new crates.io source |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@beckermr does the version bump infrastructure get the sha256 by just downloading the new version tarball and running sha256sum on that downloaded tarball? The reason I ask is that the crates.io API provides the checksum for the tarball which seems like a better place to get it than from the downloaded tarball in case there were issues with the download correct? (I've likely got this all wrong though sorry) |
Yes, the update code does a download and checksum. Unfortunately, we have no way to feed a new checksum into the version bump code for the recipe. Further, not all version update sources supply a checksum. So while you are of course correct, in practice we don't support this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
+ Coverage 76.09% 76.24% +0.15%
==========================================
Files 119 120 +1
Lines 12803 12908 +105
==========================================
+ Hits 9742 9842 +100
- Misses 3061 3066 +5 ☔ View full report in Codecov by Sentry. |
Description:
On the gitter for conda-forge someone pointed me at this script as the source for automatic version bumps. The conversation was in relation to allowing crates.io (Rust package repository) to be detected for auto version bumps. Crates can be used to build packages, but there is no auto bump functionality (as far as I can tell).
I hope what I have contributed here is okay? Not sure if I've missed anything as I am new to this codebase.
Checklist:
model updatedor no update neededCross-refs, links to issues, etc: