Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crates.io as a source for auto version bump #3008

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

mbhall88
Copy link
Contributor

Description:

On the gitter for conda-forge someone pointed me at this script as the source for automatic version bumps. The conversation was in relation to allowing crates.io (Rust package repository) to be detected for auto version bumps. Crates can be used to build packages, but there is no auto bump functionality (as far as I can tell).

I hope what I have contributed here is okay? Not sure if I've missed anything as I am new to this codebase.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above.

@mbhall88 mbhall88 requested a review from beckermr September 25, 2024 22:09
@beckermr beckermr enabled auto-merge September 25, 2024 22:24
auto-merge was automatically disabled September 26, 2024 00:04

Head branch was pushed to by a user without write access

@mbhall88
Copy link
Contributor Author

Fixed the failing test and added a full integration test for the new crates.io source

@beckermr
Copy link
Contributor

beckermr commented Sep 26, 2024

pre-commit.ci autofix

@beckermr beckermr enabled auto-merge September 26, 2024 00:11
@mbhall88
Copy link
Contributor Author

@beckermr does the version bump infrastructure get the sha256 by just downloading the new version tarball and running sha256sum on that downloaded tarball? The reason I ask is that the crates.io API provides the checksum for the tarball which seems like a better place to get it than from the downloaded tarball in case there were issues with the download correct? (I've likely got this all wrong though sorry)

@beckermr
Copy link
Contributor

Yes, the update code does a download and checksum. Unfortunately, we have no way to feed a new checksum into the version bump code for the recipe. Further, not all version update sources supply a checksum. So while you are of course correct, in practice we don't support this.

@beckermr beckermr merged commit 7ea599e into regro:main Sep 26, 2024
5 checks passed
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (3312df0) to head (7ca7367).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_upstream_versions.py 80.95% 4 Missing ⚠️
conda_forge_tick/update_sources.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
+ Coverage   76.09%   76.24%   +0.15%     
==========================================
  Files         119      120       +1     
  Lines       12803    12908     +105     
==========================================
+ Hits         9742     9842     +100     
- Misses       3061     3066       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants