Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle workspace config event #91

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

heywhy
Copy link
Contributor

@heywhy heywhy commented Mar 31, 2024

This PR includes support for handling the workspace/configurationDidChanged event. Without this feature, projects like Neoconf won't work as expected because Neoconf supports changing config for an LSP per workspace. A new published version is as soon as possible.

@heywhy heywhy requested a review from regen100 as a code owner March 31, 2024 00:39
@heywhy
Copy link
Contributor Author

heywhy commented Apr 15, 2024

@regen100 please, take a look at this. a new release is required.

@regen100
Copy link
Owner

Thank you for your pull request and sorry for the delayed response! I appreciate your contribution and look forward to incorporating it.

@regen100 regen100 merged commit 890bb77 into regen100:master Apr 20, 2024
10 checks passed
@heywhy
Copy link
Contributor Author

heywhy commented Apr 20, 2024

@regen100 thank you for helping to get this out of the way. when will a new release be made?

@heywhy
Copy link
Contributor Author

heywhy commented Apr 20, 2024

@regen100 thank you for helping to get this out of the way. when will a new release be made?

you can ignore this comment, I just updated and everything is fine. 😄

@heywhy heywhy deleted the feat-workspace-config-event branch April 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants