Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: update pygls to version 0.11.2 #42

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

charlievieth
Copy link
Contributor

Update pygls to version 0.11.2 and change the version requirement to
'^0.11' this removes a conflict with jedi-language-server which requires
pygls>=0.11.1,<0.12.0.

This commit also bumps the cmake-language-server version to 0.1.3.

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #42 (7a5dd3d) into master (4be7657) will decrease coverage by 0.10%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   93.75%   93.64%   -0.11%     
==========================================
  Files           5        5              
  Lines         464      472       +8     
==========================================
+ Hits          435      442       +7     
- Misses         29       30       +1     
Flag Coverage Δ
unittests 93.64% <93.61%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmake_language_server/server.py 86.17% <90.32%> (-0.38%) ⬇️
src/cmake_language_server/__init__.py 100.00% <100.00%> (ø)
src/cmake_language_server/api.py 94.60% <100.00%> (ø)
src/cmake_language_server/formatter.py 98.01% <100.00%> (ø)
src/cmake_language_server/parser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e34ae...7a5dd3d. Read the comment docs.

@regen100
Copy link
Owner

regen100 commented Oct 3, 2021

Thank you for the PR!
Sorry, I found CI broken. I'll fix it.

@regen100
Copy link
Owner

regen100 commented Oct 3, 2021

#44 fixed the problem and merged. Would you please rebase or merge master?

Update pygls to version 0.11.2 and change the version requirement to
'^0.11' this removes a conflict with jedi-language-server which requires
pygls>=0.11.1,<0.12.0.

This commit also bumps the cmake-language-server version to 0.1.3.
@charlievieth
Copy link
Contributor Author

Thanks for the fast review! #43 caused a fun merge conflict so I just reset to master and redid the update.

@regen100
Copy link
Owner

regen100 commented Oct 3, 2021

Good job! I'm going to release the new version soon.

@regen100 regen100 merged commit 9630b96 into regen100:master Oct 3, 2021
@charlievieth charlievieth deleted the cev/update-pygls branch July 16, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants