Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecocredit/core): use legacy params in credit type query #966

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

technicallyty
Copy link
Contributor

Description

  • refactors the credit type query to return the legacy params.

Closes: n/a


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #966 (878b7a0) into master (67035ff) will decrease coverage by 4.74%.
The diff coverage is 100.00%.

❗ Current head 878b7a0 differs from pull request most recent head 022a76a. Consider uploading reports for the commit 022a76a to get more accurate results

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   72.71%   67.97%   -4.75%     
==========================================
  Files         207      194      -13     
  Lines       23302    21491    -1811     
==========================================
- Hits        16945    14609    -2336     
- Misses       5007     5627     +620     
+ Partials     1350     1255      -95     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 67.97% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@clevinson clevinson enabled auto-merge (squash) March 31, 2022 22:35
@clevinson clevinson merged commit 639090b into master Mar 31, 2022
@clevinson clevinson deleted the ty/fix_query branch March 31, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants