-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ecocredit): update core simulations to use v1 api #928
Conversation
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 72.16% 72.94% +0.77%
==========================================
Files 211 206 -5
Lines 23653 23389 -264
==========================================
- Hits 17070 17061 -9
+ Misses 5214 4976 -238
+ Partials 1369 1352 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Nice work.
can we uncomment the sims runner now? or is there more to do after this? |
Genesis simulations are still using |
} | ||
} | ||
|
||
func genCreditTypesLegacy(r *rand.Rand) []*ecocredit.CreditType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we still need this legacy function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to finish migrating genesis from v1alpha1 to v1 (see #976). @aleem1314 can you make sure we remove the use of legacy types here in the genesis simulation with the changes in #977?
Description
Closes: #920
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change