Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecocredit): update core simulations to use v1 api #928

Merged
merged 12 commits into from
Apr 6, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Mar 24, 2022

Description

Closes: #920


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #928 (3290712) into master (24117f8) will increase coverage by 0.77%.
The diff coverage is 9.15%.

❗ Current head 3290712 differs from pull request most recent head a19de8f. Consider uploading reports for the commit a19de8f to get more accurate results

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   72.16%   72.94%   +0.77%     
==========================================
  Files         211      206       -5     
  Lines       23653    23389     -264     
==========================================
- Hits        17070    17061       -9     
+ Misses       5214     4976     -238     
+ Partials     1369     1352      -17     
Flag Coverage Δ
experimental-codecov 72.85% <9.15%> (+0.80%) ⬆️
stable-codecov 67.73% <9.15%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review April 5, 2022 12:50
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Nice work.

@technicallyty
Copy link
Contributor

can we uncomment the sims runner now? or is there more to do after this?

@aleem1314
Copy link
Contributor Author

can we uncomment the sims runner now? or is there more to do after this?

Genesis simulations are still using v1alpha2. We can enable sims after we migrate genesis state to v1 api #977.

}
}

func genCreditTypesLegacy(r *rand.Rand) []*ecocredit.CreditType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we still need this legacy function?

Copy link
Member

@ryanchristo ryanchristo Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to finish migrating genesis from v1alpha1 to v1 (see #976). @aleem1314 can you make sure we remove the use of legacy types here in the genesis simulation with the changes in #977?

@ryanchristo ryanchristo merged commit fe50121 into master Apr 6, 2022
@ryanchristo ryanchristo deleted the aleem/920-core-sims branch April 6, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/ecocredit: migrate core simulations to target v1
4 participants