Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): SellOrders query & sub-queries #917

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 21, 2022

Description

  • adds all SellOrders queries

ref: #856


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

)

// SellOrders queries all sell orders in state with optional pagination
func (k Keeper) SellOrders(ctx context.Context, req *v1.QuerySellOrdersRequest) (*v1.QuerySellOrdersResponse, error) {
Copy link
Contributor Author

@technicallyty technicallyty Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put both the SellOrdersBy... queries in the same file, seemed like a sane thing to do as they're essentially SellOrders sub-queries, but can move them to separate files if that makes more sense

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #917 (dcc5dc7) into master (07371fb) will decrease coverage by 6.93%.
The diff coverage is 54.54%.

❗ Current head dcc5dc7 differs from pull request most recent head 25387f3. Consider uploading reports for the commit 25387f3 to get more accurate results

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   72.64%   65.71%   -6.94%     
==========================================
  Files         185      179       -6     
  Lines       22742    20282    -2460     
==========================================
- Hits        16522    13329    -3193     
- Misses       4994     5800     +806     
+ Partials     1226     1153      -73     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 65.71% <54.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple nits with import names and maybe a test case using pagination would be nice. Pre-approving.

x/ecocredit/server/marketplace/query_sell_orders.go Outdated Show resolved Hide resolved
x/ecocredit/server/marketplace/query_sell_orders_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/marketplace/query_sell_orders_test.go Outdated Show resolved Hide resolved
@technicallyty technicallyty changed the title feat: SellOrders query & sub-queries feat(marketplace): SellOrders query & sub-queries Mar 22, 2022
@technicallyty technicallyty requested a review from aleem1314 March 22, 2022 20:30
@technicallyty technicallyty enabled auto-merge (squash) March 23, 2022 00:39
@technicallyty technicallyty merged commit 8d19ee6 into master Mar 23, 2022
@technicallyty technicallyty deleted the ty/856-sellorders_query branch March 23, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants