-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(marketplace): SellOrders
query & sub-queries
#917
Conversation
) | ||
|
||
// SellOrders queries all sell orders in state with optional pagination | ||
func (k Keeper) SellOrders(ctx context.Context, req *v1.QuerySellOrdersRequest) (*v1.QuerySellOrdersResponse, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put both the SellOrdersBy...
queries in the same file, seemed like a sane thing to do as they're essentially SellOrders
sub-queries, but can move them to separate files if that makes more sense
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
- Coverage 72.64% 65.71% -6.94%
==========================================
Files 185 179 -6
Lines 22742 20282 -2460
==========================================
- Hits 16522 13329 -3193
- Misses 4994 5800 +806
+ Partials 1226 1153 -73
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A couple nits with import names and maybe a test case using pagination would be nice. Pre-approving.
SellOrders
query & sub-queriesSellOrders
query & sub-queries
Description
ref: #856
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change