-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecocredit): wire up new submodules #913
Conversation
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 72.62% 72.43% -0.20%
==========================================
Files 186 195 +9
Lines 22808 22841 +33
==========================================
- Hits 16564 16544 -20
- Misses 5004 5063 +59
+ Partials 1240 1234 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. All minor suggestions. Pre-approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, looks like there might be a few other spots where we have some inconsistency left over wrt naming: params -> paramskeeper and import naming that could be cleaned up
Description
Ref: #898
Partially closes 898. Before removing
v1alpha2
msg & query server implementations we have to migrateclient
andsimulations
to usev1
.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change