-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: copy sdk.Msg impls for v1 #911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
requested review from
ryanchristo,
aaronc,
aleem1314 and
robert-zaremba
March 19, 2022 04:25
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 73.37% 72.67% -0.71%
==========================================
Files 171 184 +13
Lines 22493 22735 +242
==========================================
+ Hits 16505 16523 +18
- Misses 4820 4987 +167
- Partials 1168 1225 +57
Flags with carried forward coverage won't be shown. Click here to find out more. |
ryanchristo
reviewed
Mar 19, 2022
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
ryanchristo
approved these changes
Mar 19, 2022
aleem1314
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewers: 99.99% of this is just copy pasta, any additl' edits made were cleanup and adding t.Parallel() to all the msg tests.
Closes: #900
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change