Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): QuerySellOrder ORM #906

Merged
merged 8 commits into from
Mar 18, 2022
Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 17, 2022

Description

  • adds query endpoint for single sell order

ref: #856


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #906 (3bc98ca) into master (845be98) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   73.32%   73.32%   -0.01%     
==========================================
  Files         170      171       +1     
  Lines       22486    22493       +7     
==========================================
+ Hits        16488    16493       +5     
- Misses       4835     4836       +1     
- Partials     1163     1164       +1     
Flag Coverage Δ
experimental-codecov 73.29% <71.42%> (+0.03%) ⬆️
stable-codecov 66.52% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

x/ecocredit/server/marketplace/query_sell_order.go Outdated Show resolved Hide resolved
x/ecocredit/server/marketplace/query_sell_order_test.go Outdated Show resolved Hide resolved
@technicallyty technicallyty merged commit ab646ff into master Mar 18, 2022
@technicallyty technicallyty deleted the ty/856-query_sell_order branch March 18, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants